Joel Hooks : Building Blocks - Latest Comments

Re: Modular Robotlegs

jmp909 — Thu, 19 Jan 2012 13:15:14 -0000

for anyone interested, the slow down with multiple doodads appears to come mainly from the console logging not the modular nature. if you remove the console from the app the modules are a lot more responsive even when adding a few.

Great example thanks Joel. this and http://labs.riamore.com/conten... got me up to scratch with RobotLegs & Flex, for some of these more complicated applications of the frameworks, from a beginner in in a few days

Re: Robotlegs, AS3-Signals and the SignalCommandMap Example

jmp909 — Fri, 13 Jan 2012 18:50:38 -0000

Ok i updated my SignalsCommandMap swc to the v0.4 version and along with my constructor fix in FoodItemSelected everything works without warnings now

SWCs used:
as3-signals-v0.8.swc, robotlegs-framework-v1.5.2.swc,
signals-extension-SignalsCommandMap-v0.4.swc,
SwiftSuspenders-v1.5.1.swcHope this is useful to people

Re: Robotlegs, AS3-Signals and the SignalCommandMap Example

jmp909 — Fri, 13 Jan 2012 18:39:06 -0000

sorry about that.. line breaks not showing.. those other parts are my trace outputs to follow the function signal flow.. the warning is:

Warning: Injector already has a rule for type "org.robotlegs.examples.signalcommands.model.enums::FoodType", named "". If you have overwritten this mapping intentionally you can use "injector.unmap()" prior to your replacement mapping in order to avoid seeing this message.

Re: Robotlegs, AS3-Signals and the SignalCommandMap Example

jmp909 — Fri, 13 Jan 2012 18:37:48 -0000

i've managed to get this sort of working with:
as3-signals-v0.8.swcrobotlegs-framework-v1.5.2.swcsignals-extension-SignalsCommandMap.swcSwiftSuspenders-v1.5.1.swchowever note the following..

I had to add a constructor function to the FoodItemSelected signal

public class FoodItemSelected extends Signal { public function FoodItemSelected() { super(FoodItem); } }

this removes the following error that was occurring with other versions:

[Fault] exception, information=Error: Injector is missing a rule to handle injection into property "item" of object "[object FoodItemSelectedCommand]". Target dependency: "org.robotlegs.examples.signalcommands.model.vo::FoodItem", named ""

but there's a warning on the Injector...

AddFoodItemToOrder::FoodSelectionView::addFoodItem_clickHandlerFoodSelectionViewMediator::handleItemTypeAddedAddFoodItemToOrderCommand::executeFoodOrderModel::addItemToOrderCurrentOrderViewMediator::updateOnItemAddedFoodItemSelectedCommand::executeCurrentOrderViewMediator::updateOnOrderUpdatedFoodSelectionView::addFoodItem_clickHandlerFoodSelectionViewMediator::handleItemTypeAddedWarning: Injector already has a rule for type "org.robotlegs.examples.signalcommands.model.enums::FoodType", named "". If you have overwritten this mapping intentionally you can use "injector.unmap()" prior to your replacement mapping in order to avoid seeing this message.

I'm not sure what's happening there then. The application works now, but there's obviously still an issue

j

Re: Robotlegs 2 (beta): Flickr Image Gallery

Robert Penner — Wed, 04 Jan 2012 22:45:10 -0000

> "this just doesn't make any sense to dig through the context to get at the dependency that I really want."

I agree. The IContextConfigs currently in Robotlegs 2 have a lot of code like:

context.injector.getInstance(IMediatorMap)

Using the context to get the injector to pull out a dependency from the injector--this gets my Demeter-sense tingling. I feel it would be more straightforward to just inject the IMediatorMap into something and skip the pretext of "configuring the context".

Re: Robotlegs 2 (beta): Flickr Image Gallery

Robert Penner — Wed, 04 Jan 2012 22:21:58 -0000

I agree with you on the last point. Obviously making custom Events is not my favourite thing, either.

Re: Robotlegs 2 (beta): Flickr Image Gallery

Robert Penner — Wed, 04 Jan 2012 22:19:28 -0000

Or you could *gasp* execute the command manually. =) Your point is taken, though. Maybe we should make it easier to execute commands then. Or make it easier to inject into functions in general.

Re: Robotlegs 2 (beta): Flickr Image Gallery

shaun — Wed, 04 Jan 2012 09:07:03 -0000

Continued over at: https://github.com/robotlegs/r...

Re: Robotlegs 2 (beta): Flickr Image Gallery

shaun — Wed, 04 Jan 2012 09:06:04 -0000

Remember that the context is not fully initialized at those points, and all dependencies have not necessarily been mapped, so automated injection into those configs is not feasible.

Re: Robotlegs 2 (beta): Flickr Image Gallery

shaun — Wed, 04 Jan 2012 09:02:47 -0000

Also, Commands can only be executed IF a command map extension has been installed AND the builder and context are already configured.

Re: Robotlegs 2 (beta): Flickr Image Gallery

Joel Hooks — Tue, 03 Jan 2012 19:27:28 -0000

Actually, I think we agree. I like using a command. I think this is a command, it just has an extraneous argument being passed in to it's execution method.

Re: Robotlegs 2 (beta): Flickr Image Gallery

Joel Hooks — Tue, 03 Jan 2012 19:17:35 -0000

It effectively is a command, but with a distinct purpose (configuring a context). We can agree to disagree I guess. I always thought the "kick off a Command with an event to string Commands and configure the context" was clunky and obtuse. This I like.

Re: Robotlegs 2 (beta): Flickr Image Gallery

Robert Penner — Tue, 03 Jan 2012 18:13:38 -0000

I responded to the ContextBuilder thread here:
https://github.com/robotlegs/r...

Re: Robotlegs 2 (beta): Flickr Image Gallery

Stray — Tue, 03 Jan 2012 17:37:18 -0000

Yes. Sorry - 10.30 pm here and been working on a building site most of the day. I can only grunt.

Re: Robotlegs 2 (beta): Flickr Image Gallery

Robert Penner — Tue, 03 Jan 2012 17:32:14 -0000

> "IConfig has a bunch of stuff like parent..."

Er, IContext. =)

Re: Robotlegs 2 (beta): Flickr Image Gallery

Robert Penner — Tue, 03 Jan 2012 17:15:17 -0000

To be clear, I was never objecting to injecting the dependencies and operating on them. But in this case, a command would be a better tool for that.

Re: Robotlegs 2 (beta): Flickr Image Gallery

Stray — Tue, 03 Jan 2012 17:04:09 -0000

@Robert - IConfig has a bunch of stuff like parent, logger, app domain and dispatcher which all might be useful in configuring - not just the injector.

You can set as well as get some of these (eg contextView). We went with withConfig(expectsAClassThatImpsIConfig). We did um and ah about whether to simply expect people to make their own and use [PostConstruct] but prescription has been something people have liked when getting started.

Maybe pick this up on the GitHub stuff around API for the context builder? I think Shaun has his head best wrapped around the deets on this issue.

Good to have you back :)

Stray

Re: Robotlegs 2 (beta): Flickr Image Gallery

Joel Hooks — Tue, 03 Jan 2012 16:49:43 -0000

It works, it makes sense, and provides an effective approach to configuring the actors within a given Context.

I've looked at the other configs.

const mediatorMap:robotlegs.bender.extensions.mediatorMap.api.IMediatorMap = context.injector.getInstance(IMediatorMapV2);

this just doesn't make any sense to dig through the context to get at the dependency that I really want.

or


		public function configure(context:IContext):void		{			if (contextView)			{				context.logger.info(this, 'Adding contextView to viewManager. Note: avoid this where performance is critical.');				viewManager.addContainer(contextView);			}			else			{				context.logger.warn(this, 'ContextViewListenerConfig was installed, but the contextView is null. Consider removing this config.');			}		}

in every case the IContext dependency is utilized, it is simply to attach to some other dependency of the IContext.

So, in this example the tool provided is being used appropriately, but perhaps it is the tool itself that is irritating you.

(code formatter failure)

Re: Robotlegs 2 (beta): Flickr Image Gallery

Joel Hooks — Tue, 03 Jan 2012 16:40:35 -0000

As a user, I want to "configure my context" - which I take to mean setting up my views, commands, and injections for a given Context.

In this case I needed the injector. You suggested I throw in context.injector just because the IContext is available. I'd rather have all my dependencies lined up and provided in the same fashion and prefer to access it at the "top level" without digging into a class I'm not interested in.

I've never had a use for manipulating a Context directly after startup().

Re: Robotlegs 2 (beta): Flickr Image Gallery

Robert Penner — Tue, 03 Jan 2012 16:39:49 -0000

It's about using the right tool for the job. In this example, an IContextConfig is not the right tool.

Re: Robotlegs 2 (beta): Flickr Image Gallery

Robert Penner — Tue, 03 Jan 2012 16:34:59 -0000

> "I am configuring a context."

You said "I don't need the IContext. I need the injector." Which one are you configuring?

> "I never once thought that IContextConfig was referring to manipulating or interacting with an instance of an IContext."

Um... what?

public interface IContextConfig{ function configure(context:IContext):void;}

Re: Robotlegs 2 (beta): Flickr Image Gallery

Joel Hooks — Tue, 03 Jan 2012 16:21:53 -0000

where does that lead? IMediatorMapConfig ISomeCustomCommandMapImplementationConfig?

I am configuring a context. Outside of preferring not to use [Inject] for supplying dependencies, I don't get the beef. It was easy to supply the injector, and makes sense in the context (lowercase c) of a Robotlegs application.

I never once thought that IContextConfig was referring to manipulating or interacting with an instance of an IContext. I think the interface should lose the reference to the IContext and not imply that there is a need to manipulate an instance of the Context. What is the use case for that? It would be available for injection regardless...

IConfig with a configure() method. It *is* essentially a command, but with a targeted purpose.

Re: Robotlegs 2 (beta): Flickr Image Gallery

Joel Hooks — Tue, 03 Jan 2012 16:14:48 -0000

The interface isn't ignored, the IContext injected by the method is ignored. It *is* configuring a context in the body of the method expressed by the interface. I don't see how it is better off in command. Because in this simple contrived example the dependency isn't used? Meh.

Re: Robotlegs 2 (beta): Flickr Image Gallery

Robert Penner — Tue, 03 Jan 2012 16:04:30 -0000

I suspect IContextConfig may need to be replaced/supplemented with something like IInjectorConfig which supplies the injector to configure().

Re: Robotlegs 2 (beta): Flickr Image Gallery

Robert Penner — Tue, 03 Jan 2012 15:46:59 -0000

>
I don't need the IContext. I need the injector.

Exactly. Why then did you make it an IContextConfig? Just so Robotlegs would execute it? Better off leaving it as a command. "Cheating and missing the point" refers to GalleryAppConfig implementing an interface it promptly ignores.